Skip to content

AudienceNetwork (S2S): add missing ext.security_app_id in OpenRTB requests to fix production auth failures #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+13 −4
Open

AudienceNetwork (S2S): add missing ext.security_app_id in OpenRTB requests to fix production auth failures #4196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffb6697
AudienceNetwork adapter optimize in production
PeakLee Sep 19, 2025
c021d3e
AudienceNetwork adapter optimize in production
PeakLee Sep 19, 2025
4ba4227
AudienceNetwork adapter: fix checkstyle issue and import missed JsonP…
PeakLee Sep 20, 2025
6ee5138
AudienceNetwork adapter: update test to include additional parameter …
PeakLee Sep 22, 2025
740292a
AudienceNetwork adapter: add security_app_id to bid request JSON
PeakLee Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/org/prebid/server/bidder/audiencenetwork/AudienceNetworkBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ private HttpRequest<BidRequest> makeHttpRequest(Imp imp, BidRequest bidRequest,
final BidRequest outgoingRequest = bidRequest.toBuilder()
.imp(Collections.singletonList(modifiedImp))
.app(makeApp(bidRequest.getApp(), publisherId))
.ext(mapper.fillExtension(
ExtRequest.empty(), AudienceNetworkExt.of(platformId, makeAuthId(bidRequest.getId()))))
.ext(mapper.fillExtension(ExtRequest.empty(),
AudienceNetworkExt.of(platformId, makeAuthId(bidRequest.getId()),
platformId)))
Comment on lines +120 to +122
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix formatting

.ext(mapper.fillExtension(
        ExtRequest.empty(),
        AudienceNetworkExt.of(platformId, makeAuthId(bidRequest.getId()), platformId)))

.build();

return HttpRequest.<BidRequest>builder()
Expand Down
6 changes: 6 additions & 0 deletions src/main/java/org/prebid/server/bidder/audiencenetwork/proto/AudienceNetworkExt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
package org.prebid.server.bidder.audiencenetwork.proto;

import com.fasterxml.jackson.annotation.JsonProperty;
import lombok.Value;

@Value(staticConstructor = "of")
public class AudienceNetworkExt {

@JsonProperty("platformid")
String platformid;

@JsonProperty("authentication_id")
String authenticationId;

@JsonProperty("security_app_id")
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JsonPropertys are redundant here, please remove

String securityAppId;
}
3 changes: 2 additions & 1 deletion src/test/java/org/prebid/server/bidder/audiencenetwork/AudienceNetworkBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,8 @@ public void makeHttpRequestsShouldChangeRequestExt() {
.containsOnly(
AudienceNetworkExt.of(
"101",
"bd49902da11ce0fe6258e56baa0a69c2f1395b2ff1efb30d4879ed9e2343a3f6"));
"bd49902da11ce0fe6258e56baa0a69c2f1395b2ff1efb30d4879ed9e2343a3f6",
"101"));
}

@Test
Expand Down
3 changes: 2 additions & 1 deletion ...urces/org/prebid/server/it/openrtb2/audiencenetwork/test-audiencenetwork-bid-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
},
"ext": {
"authentication_id": "48b7d18b921be9887a5351f31cc85f1326e3da1d8c402dec2bd338cf10bd6b43",
"platformid": "101"
"platformid": "101",
"security_app_id": "101"
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask you to change values of the properties to something more readable like

"authentication_id": "authentication_id",
"platformid": "platformid",
"security_app_id": "platformid"

It'll be much more readable

P.S. I'd nice if you do the same in the AudienceNetworkBidderTest

Copy link
Author

@PeakLee PeakLee Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks @AntoxaAntoxic

}
}
Loading