Skip to content

AudienceNetwork (S2S): add missing ext.security_app_id in OpenRTB requests to fix production auth failures #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+13 −4
Open

AudienceNetwork (S2S): add missing ext.security_app_id in OpenRTB requests to fix production auth failures #4196

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffb6697
AudienceNetwork adapter optimize in production
PeakLee Sep 19, 2025
c021d3e
AudienceNetwork adapter optimize in production
PeakLee Sep 19, 2025
4ba4227
AudienceNetwork adapter: fix checkstyle issue and import missed JsonP…
PeakLee Sep 20, 2025
6ee5138
AudienceNetwork adapter: update test to include additional parameter …
PeakLee Sep 22, 2025
740292a
AudienceNetwork adapter: add security_app_id to bid request JSON
PeakLee Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/bidder/audiencenetwork/AudienceNetworkBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ private HttpRequest<BidRequest> makeHttpRequest(Imp imp, BidRequest bidRequest,
.imp(Collections.singletonList(modifiedImp))
.app(makeApp(bidRequest.getApp(), publisherId))
.ext(mapper.fillExtension(
ExtRequest.empty(), AudienceNetworkExt.of(platformId, makeAuthId(bidRequest.getId()))))
ExtRequest.empty(), AudienceNetworkExt.of(platformId, makeAuthId(bidRequest.getId()), platformId)))
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platformId parameter is passed twice - once for the platformid field and again for the securityAppId field. Consider extracting this to a variable or adding a comment explaining why the same value is used for both fields to improve code clarity.

Copilot uses AI. Check for mistakes.
.build();

return HttpRequest.<BidRequest>builder()
Expand Down
6 changes: 5 additions & 1 deletion src/main/java/org/prebid/server/bidder/audiencenetwork/proto/AudienceNetworkExt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@

@Value(staticConstructor = "of")
public class AudienceNetworkExt {

@JsonProperty("platformid")
String platformid;

@JsonProperty("authentication_id")
String authenticationId;

@JsonProperty("security_app_id")
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JsonPropertys are redundant here, please remove

String securityAppId;
}
Loading