feat: add composition API product authoring#1345
Closed
bokelley wants to merge 1 commit into
Closed
Conversation
0631c86 to
938155f
Compare
938155f to
2cf1b31
Compare
Collaborator
Author
|
Closing: this PR was opened against prebid/salesagent by mistake. The work is intended for bokelley/salesagent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expert review
Tests
make qualityscripts/run-test.sh tests/integration/test_composition_api.py tests/integration/test_tenant_signal_flow.py -quv run pytest tests/unit/test_openapi_export_in_sync.py tests/unit/test_architecture_no_raw_select.py tests/unit/test_architecture_repository_pattern.py -quv-secure(test-results/220526_1921/)get_productsandget_signalsdiscover them.Note: I also attempted the Docker e2e harness (
./run_all_tests.sh ci tests/e2e/test_composition_api_e2e.py -q), but it blocked before app tests on global Docker buildx contention resolvingdocker/dockerfile:1.4. The same e2e path passed against a locally served app with the agent Postgres DB.