Addition of feature "spread-profile"#623
Open
franiqui wants to merge 3 commits intoprecice:masterfrom
Open
Conversation
Addition of feature "spread-profile" in axial-geometric-multiscale mapping.
franiqui
changed the title
Author
|
@MakisH here you have my PR for the addition of the feature "spread-profile" |
MakisH
reviewed
Nov 3, 2025
MakisH
approved these changes
Nov 3, 2025
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Looks good, I added some small points, and added a version alert.
Still needs precice/precice#2386 to be merged.
| When using a `"spread"` mapping, the 1D quantity is distributed over the 3D interface using the `spread-profile`, which defines how the value varies radially across the circular interface. It can either be `"uniform"`, where the same value is applied to all interface vertices; or `"parabolic"`, in which a parabolic profile is applied (maximum at the centerline, decreasing to zero at the wall). | ||
|
|
||
| Since the 1D participant likely computes average quantities, e.g., the average pressure and velocity in a pipe, a velocity profile has to be assumed in order to convert data between the 1D and 3D participant for the axial mapping. Currently, a laminar flow profile is imposed by default, but different profiles might be supported in the future. | ||
| Since the 1D participant likely computes average quantities, e.g., the average pressure and velocity in a pipe, a velocity profile has to be assumed in order to convert data between the 1D and 3D participant for the axial mapping. By default, a laminar flow profile is imposed, but this can be explicitly controlled via the `spread-profile` attribute in the configuration. |
Member
There was a problem hiding this comment.
Since the option is not yet in a released version of preCICE, let's add a version note:
Suggested change
| Since the 1D participant likely computes average quantities, e.g., the average pressure and velocity in a pipe, a velocity profile has to be assumed in order to convert data between the 1D and 3D participant for the axial mapping. By default, a laminar flow profile is imposed, but this can be explicitly controlled via the `spread-profile` attribute in the configuration. | |
| Since the 1D participant likely computes average quantities, e.g., the average pressure and velocity in a pipe, a velocity profile has to be assumed in order to convert data between the 1D and 3D participant for the axial mapping. By default, a laminar flow profile is imposed, but this can be explicitly controlled via the `spread-profile` attribute in the configuration. | |
| {% version 3.4.0 %} | |
| The `spread-profile` option is currently only available in the `develop` branch of preCICE. Until v3.3.0, there was no option to switch off the parabolic profile. | |
| {% endversion %} |
Member
|
Still needs some updates originating from recent changes in precice/precice#2386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of feature "spread-profile" in axial-geometric-multiscale mapping.