aria-controls on multiselect panel #8241
Merged
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coderxrohan
approved these changes
Jan 3, 2026
Contributor
There was a problem hiding this comment.
Issue
MultiSelect did not expose a proper ARIA relationship between the input and the panel, which reduced accessibility and made it harder for assistive technologies to associate the combobox with its listbox.
Fix
Introduces a stable inputId using UniqueComponentId, adds aria-controls on the input, and wires the same ID to the panel list via id, ensuring correct combobox–listbox linkage.
Impact
Improves accessibility and ARIA compliance for MultiSelect, especially for screen readers, without affecting existing behavior or API usage.
melloware
force-pushed
the
multi-select-aria-controls
branch
from
d0a39db to
5c1e112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8239