Skip to content

Conversation

@FrancMunoz
Copy link

@FrancMunoz FrancMunoz commented Dec 19, 2025

There is a small issue introduced in the refactor of the Carousel in v11-alpha-9 that breaks the content inside of Carousel's items. In file useCarousel.ts some styles are set. One of them is the gap with the spacing prop, that is correct. The problem is that it uses the --spacing variable and overwrites it with the gap. This variable is used below and works well.

The issue comes with the content, as --spacing is overwritten all the tailwind gaps use the new value (16px by default) breaking the content layout.

This PR fixes the issue #8445 .

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@FrancMunoz
Copy link
Author

@tanerengiiin Is it mandadory to create an issue for the alpha version of v11? Can you please take a look into it. Thank you!

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@FrancMunoz FrancMunoz changed the title fix(Carousel): Fix CSS variable collision fix(Carousel): Fix CSS variable collision fixes #8445 Dec 19, 2025
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@FrancMunoz FrancMunoz changed the title fix(Carousel): Fix CSS variable collision fixes #8445 fix(Carousel): Fix CSS variable collision Dec 19, 2025
@melloware melloware added this to the 11.0.0 milestone Dec 19, 2025
@Coderxrohan
Copy link
Contributor

@melloware
Gentle follow-up — this looks ready to merge now.

Copy link
Contributor

@Coderxrohan Coderxrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scoping the spacing to --spacing-items avoids the global collision, and the basis calculation is handled correctly. Looks good to merge.

@melloware melloware changed the title fix(Carousel): Fix CSS variable collision fix(Carousel): V11 Fix CSS variable collision Jan 4, 2026
@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 5, 2026
@tanerengiiin tanerengiiin merged commit 358fce3 into primefaces:v11 Jan 6, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Review Issue or pull request is being reviewed by Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v11] Carousel: CSS Variable collision with Tailwind breaks items layout

4 participants