Skip to content

Fix #8449: Nested SplitterPanel detection logic #8448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melloware merged 3 commits into from
Dec 29, 2025
+58 −4
Merged

Fix #8449: Nested SplitterPanel detection logic #8448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
234e468
Fix: [Splitter] Nested SplitterPanel detection logic
usrlocl Dec 28, 2025
9152720
fix formatting
usrlocl Dec 29, 2025
98cd1c3
fix formatting
usrlocl Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/doc/common/docsectionnav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,11 @@ export function DocSectionNav({ docs = [] }) {
style={{
display: 'flex',
justifyContent: 'center',
marginTop:'1rem'
marginTop: '1rem'
}}
>
<a href="https://primeui.store" target="_blank" rel="noopener" className='p-button p-component p-button-rounded p-button-sm'>
<span className='p-button-label p-c'>Buy Now</span>
<a href="https://primeui.store" target="_blank" rel="noopener" className="p-button p-component p-button-rounded p-button-sm">
<span className="p-button-label p-c">Buy Now</span>
</a>
</span>
</div>
Expand Down
2 changes: 1 addition & 1 deletion components/lib/splitter/Splitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export const Splitter = React.memo(
prevSize.current = panelSize(panelSizes, 0);
_panelSizes[i] = panelSize(panelSizes, i);

if (panelElement.childNodes && ObjectUtils.isNotEmpty(DomHandler.find(panelElement, "[data-pc-name='splitter']") && DomHandler.find(panelElement, "[data-pc-section='root']"))) {
if (panelElement.childNodes && ObjectUtils.isNotEmpty(DomHandler.find(panelElement, "[data-pc-name='splitter']")) && ObjectUtils.isNotEmpty(DomHandler.find(panelElement, "[data-pc-section='root']"))) {
!isUnstyled() && DomHandler.addClass(panelElement, 'p-splitter-panel-nested');
panelElement.setAttribute('data-p-splitter-panel-nested', true);
setNested(true);
Expand Down
10 changes: 10 additions & 0 deletions components/lib/splitter/Splitter.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,14 @@ describe('Splitter', () => {
</>,
'Without panels'
);
snapshot(
<>
<Splitter style={{ height: '300px' }} layout="vertical">
<SplitterPanel>
<div data-pc-section="root" />
</SplitterPanel>
</Splitter>
</>,
'Single Panel with some other nested prime component'
);
});
44 changes: 44 additions & 0 deletions components/lib/splitter/__snapshots__/Splitter.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,3 +341,47 @@ exports[`Splitter Without panels 1`] = `
/>
</div>
`;

exports[`Splitter Single Panel with some other nested prime component 1`] = `
<div>
<div
class="p-splitter p-component p-splitter-vertical"
data-p-splitter-resizing="false"
data-pc-name="splitter"
data-pc-section="root"
style="height: 300px;"
>
<div
class="p-splitter-panel"
data-p-splitter-panel-nested="false"
data-pc-section="splitterpanel.root"
id="pr_id_9_0"
role="presentation"
style="flex-basis: calc(100% - 0px);"
>
<div
data-pc-section="root"
/>
</div>
<div
class="p-splitter-gutter"
data-p-splitter-gutter-resizing="false"
data-pc-section="gutter"
style="height: 4px;"
>
<div
aria-controls="pr_id_9_0"
aria-orientation="horizontal"
aria-valuemax="100"
aria-valuemin="0"
aria-valuenow="100"
aria-valuetext="100%"
class="p-splitter-gutter-handle"
data-pc-section="gutterhandler"
role="separator"
tabindex="0"
/>
</div>
</div>
</div>
`;
Loading