fix(datatable): prevent stale closures when cellMemo is enabled #8451
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
cellMemois enabled, memoized DataTable cells are not re-rendered forexisting rows when new rows are added, which can lead to stale closures in
bodyevent handlers.Solution
This change replaces
indexwithrowIndexincellMemoProps, ensuringmemoized cells are refreshed when row structure changes, while preserving
existing memoization behavior.
Notes
build:packagewas not run on Windows due to missing generated assets (components/libicons)Fixes #8450 ( PrimeReact Datatable cellMemo causes stale closures in event handlers )