Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Prepares release 1.5.0 by bumping the project version and adding support for a new PASSKEY token type plus utility methods and improved HTTP response handling/logging.
- Adds PIResponse.hasChallenges() and passkey challenge handling in JSON parsing.
- Introduces PASSKEY token parsing branch and adjusts AsyncRequestCallable logging and resource management.
- Updates project version to 1.5.0 and reorders okhttp dependency.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/org/privacyidea/PIResponse.java | Adds hasChallenges() helper to detect presence of different challenge types. |
| src/main/java/org/privacyidea/JSONParser.java | Adds PASSKEY token type handling; imports constant and sets passkeyChallenge. |
| src/main/java/org/privacyidea/AsyncRequestCallable.java | Refactors response handling with try-with-resources and modifies logging logic. |
| pom.xml | Bumps artifact version to 1.5.0 and repositions okhttp dependency. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| else if (TOKEN_TYPE_PASSKEY.equals(type)) | ||
| { | ||
| response.passkeyChallenge = challenge.toString(); |
There was a problem hiding this comment.
Using challenge.toString() with Gson may serialize a JsonPrimitive string including quotes or a JsonObject's full JSON; if passkeyChallenge is expected to be the raw string value, use challenge.getAsString(). If an object is expected, assign challenge.getAsJsonObject() and adjust the target type.
Suggested change
| response.passkeyChallenge = challenge.toString(); | |
| response.passkeyChallenge = challenge.getAsString(); |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lukasmatusiewicz
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.