Repository navigation
Update the Probitas plugin for Probitas 2.0 - #2
Merged
Merged
Conversation
Probitas 2.0 ships as a single Bun-built binary, so `deno doc` is no longer available to users, and `jsr:@probitas/expect` is no longer the package scenarios depend on. Read the method names from the type declarations of the `@probitas-test/expect` npm package instead: from the project's node_modules when the `package.json` written by `probitas init` is installed, otherwise from the published tarball. Also drop the Deno KV interfaces (the client was removed in 2.0) and the `RedisExpectation`-style names, which are conditional types without methods. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
Probitas 2.0 runs scenarios on Bun inside a single binary, so the guidance written for the Deno-based 1.x leads to scenarios that no longer type-check or run: - Import from `@probitas-test/probitas` instead of `jsr:@probitas/probitas` - Use Node.js APIs (`process.env`, `node:fs/promises`, ...) instead of `Deno.*`, with `@types/node` and `"types": ["node"]` for `probitas check` - Install third-party modules via package.json; `npm:`/`jsr:` specifiers are not resolved - Drop the removed Deno KV client - Document the 2.0 install channels (install.sh piped to sh, Homebrew `probitas-test/tap/probitas`, setup-probitas@v2, Nix flake) and how to stay on 1.x - Describe the files `probitas init` writes and installing its package.json - Describe the built-in fmt/lint/check behaviour, including biome-ignore - Point API lookups at the npm type declarations and the JSR reference instead of `deno doc` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
The plugin version follows the Probitas CLI version it documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
Probitas 2.0 no longer involves Deno, so research the API through the JSR reference and the npm type declarations. Also drop the removed probitas-new command from the command list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
The dev shell now provides the Probitas 2.0.0 release binary, matching the behaviour the plugin documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/probitas-expect-methodsno longer runsdeno doc jsr:@probitas/expect: it reads the@probitas-test/expecttype declarations from the project'snode_modules(npm, bun and pnpm layouts) and falls back to the latest npm tarball. Deno KV interfaces are gone;AnythingExpectationis listed for plain values.scenario-writeragent: imports from@probitas-test/probitas,process.envinstead ofDeno.env, a table mappingDeno.*to Node.js APIs, third-party modules viapackage.jsonwith bare imports, the@types/node/"types": ["node"]requirement, Deno KV removed, an "API Docs" section the agent already referred to, and checklist items forjsr:/npm:specifiers andDeno.*.probitas-info/probitas-setupskills and/probitas-init,/probitas-check: single binary (no Deno), 2.0 install paths (install.sh, Homebrew,setup-probitas@v2, Nix flake, staying on 1.x), the filesprobitas initwrites and installing itspackage.json, fmt/lint/check in 2.0 terms with troubleshooting, and a link to MIGRATION.md.Why
Probitas 2.0 runs on Bun as a single binary. The plugins still taught Deno-era scenarios (
jsr:imports,Deno.env, Deno KV), and/probitas-expect-methodsdepended ondeno doc, so on a machine with only Probitas 2 it could not work. See MIGRATION.md.@types/nodematters becauseprobitas check(built-inbun check, TypeScript 7 semantics) loads only the@typespackages listed intsconfig.json;probitas initin 2.0.0 does not add it yet (probitas-test/probitas#119).Test Plan
deno fmt --checkin the dev shell (the repo's only check; Deno here formats this repo's Markdown, not Probitas)/probitas-expect-methodslookup against the published@probitas-test/expect0.5.0 (the version@probitas-test/probitas2.0.0 depends on), fromnode_modulesand from the npm tarballprobitas --versionreports 2.0.0🤖 Generated with Claude Code
https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq