Repository navigation
Apply the oss-init conventions and rename the Go modules - #4
Merged
Merged
Conversation
CI checked each server with its own fmt/lint/test/build steps, and nothing checked the Markdown, JSON and YAML formatting or the Nix files. Each server now has a `ci` recipe (lint, fmt-check, test, build) whose fmt-check fails when the formatter itself fails, and the root `ci` runs them all plus `fmt-check`, which runs dprint and nixfmt across the repository. The flake lists its systems with nixpkgs.lib.genAttrs instead of flake-utils and is formatted with nixfmt, which the dev shell now provides. The repository ignores its own /.envrc and worktrees, and .gitattributes keeps checkouts LF on every OS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
The repository had no guide for agents. AGENTS.md describes the layer table, the quality gate (`just ci`), the layout and the commit convention in use, and the ADR and spec procedures land with the rules that make them get read, so records written from here on follow them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
The build workflows ran their checks as separate jobs, each wrapping its commands in `nix develop -c`. Each now has one build job that loads the dev shell with nicknovitski/nix-develop and runs the server's `ci` recipe, and a new Format workflow runs `just fmt-check` on every change, since formatting is not tied to one server. Workflows read the repository by default and widen permissions per job, checkouts no longer keep credentials, pull request runs cancel superseded ones while main and publish runs finish, and the actions are on their latest majors. The image tags and when images are pushed stay as they were. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
The modules were still github.com/probitas-test/state-servers/..., the repository's former name, and the README badges linked that repository's workflows. Both now use github.com/probitas-test/trap-servers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cirecipe (lint, fmt-check, test, build) and the rootjust ciruns them all plusjust fmt-check(dprint and nixfmt). The flake drops flake-utils and is nixfmt-formatted;.gitignoreuses/.envrcand ignores worktrees,.gitattributeskeeps LF.AGENTS.md(layer table, gate, layout, commit convention) with the ADR/spec procedures and rules.buildjob (nix-develop +just <server>::ci); a new Format workflow runsjust fmt-check. Top-levelcontents: read,persist-credentials: false, PR runs cancel / main runs finish, docker actions on their latest majors. Image tags and push triggers unchanged.github.com/probitas-test/trap-servers/...instead of the formerstate-serversname, and the README badges link this repository's workflows.Why
Brings the repository in line with the oss-init conventions used across the org, and checks repository-wide formatting in CI, which nothing did before.
Test Plan
nix develop -c just ci(tests, build, dprint, nixfmt)nix flake check --no-build,actionlint🤖 Generated with Claude Code
https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq