[Debug] Use larger runner for (most) integration test suites#1032
Draft
cpuguy83 wants to merge 3 commits intoproject-dalec:mainfrom
Draft
[Debug] Use larger runner for (most) integration test suites#1032cpuguy83 wants to merge 3 commits intoproject-dalec:mainfrom
cpuguy83 wants to merge 3 commits intoproject-dalec:mainfrom
Conversation
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
use_larger_runners
branch
8 times, most recently
from
4ee4703 to
52d00ea
Compare
cpuguy83
commented
Apr 9, 2026
| - name: Setup source policy | ||
| if: inputs.source_policy | ||
| uses: ./.github/actions/setup-source-policy | ||
| - name: Aggressive cleanup |
Collaborator
Author
There was a problem hiding this comment.
Disks are larger on the updated runners and this step takes 3mins by itself to run, so just not worth it anymore.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the CI integration-test job to use a larger GitHub Actions runner for most suites and improves docker/containerd restart diagnostics during CI setup.
Changes:
- Switch
integrationjob runner selection to a conditional matrix-based runner (larger runner for most suites). - Add a Docker diagnostics step and tighten docker/containerd restart handling during OTEL tracing setup.
- Update composite actions to stop/start Docker with clearer failure reporting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Conditional runner selection for integration suites; adds Docker info; changes docker/containerd lifecycle around tracing setup; removes aggressive disk cleanup. |
| .github/actions/enable-containerd/action.yml | Stops/starts Docker when enabling containerd snapshotter and emits logs on failure. |
| .github/actions/dns-spoof-ubuntu-archive/action.yml | Stops/starts Docker after writing daemon DNS config and emits logs on failure. |
cpuguy83
commented
Apr 9, 2026
|
|
||
| integration: | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ${{ matrix.suite == 'other' && 'ubuntu-22.04' || 'ubuntu-latest-4-cores' }} |
Collaborator
Author
There was a problem hiding this comment.
The runners we have access to are all ubuntu-latest-<n>-cores
After switching to larger runners CI had 3 jobs where dockerd just would not start. Seemingly because we are restarting docker (for config updates) quickly enough such that systemd refuses to restart it. This change resets the fail counter in systemd if docker fails to restart and tries again. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
use_larger_runners
branch
from
52d00ea to
86fbcc1
Compare
Add timeout signaling from test2json2gha to GITHUB_OUTPUT so subsequent CI steps can detect when tests timed out. On timeout, the dump logs step now collects goroutine stacks, a binary heap profile, and the dockerd binary from the runner for offline analysis with go tool pprof. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
use_larger_runners
branch
from
5288397 to
8409f8e
Compare
cpuguy83
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.