Conversation
Dev<->main 동기화
Dev <-> main
Dev<->main
Dev<->main 동기화
- Note 생성시 type 필드 포함 강제 - Note 조회시 type 필드 추가
…사 첨부되어 있지 않은 경우 에러 일으키도록
elive7
approved these changes
Jan 19, 2026
Contributor
elive7
left a comment
elive7
left a comment
There was a problem hiding this comment.
너무 늦게 리뷰해서 죄송해요... 수고하셨습니다
| } | ||
|
|
||
| @GetMapping | ||
| @GetMapping("/users/notes") |
Contributor
There was a problem hiding this comment.
/user로 시작하는데도 NoteController에 적은 이유가 따로 있나요? 수정을 할 필요는 없을 것 같은데 궁금해요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍃 Pull Requests
⛳️ 작업한 브랜치
👷 작업한 내용
notes에 enum 타입의 컬럼type을 추가해야 한다.notes레코드는 모두FREE타입으로 처리한다.type을 추가해야 한다.type을 받는다.type에 따라 가사 첨부를 강제한다.LYRICS_ANALYSISFREE,QUESTION/api/v1/notes)의 URI를/api/v1/users/notes로 이전한다./api/v1/notes/favorite-artists)를 제거하고, 새로운 검색 API에 통합한다.findAllByArtistIds()에서ByArtistIds가 빠진 버전으로findAll()을 구현한다.getNotes()을 구현한다.NoteController.getNotes()에서hasFavoriteArtist파라미터에 따라서getNotes()/getNotesOfFavoriteArtists분기 처리한다.🚨 참고 사항