Skip to content

Conversation

@pschichtel
Copy link
Member

As suggested in #3 a PR that introduces a chart for the gateway provisioner. I needed to build this anyway, because we standardized on deployments using helm. As a preparation I've also added a chart for the CRDs, which could be pulled by the main contour chart as well.

What I considered, but didn't do in this PR:

  • change the contour chart to pull contour-crds
  • pull the gateway-api CRDs via oci://docker.io/envoyproxy/gateway-crds-helm

@pschichtel
Copy link
Member Author

I bootstrapped the contour-gateway-provisioner chart using helm create and then reduced that to what's needed and merged in the non-crd resources from the official manifest file.

@pschichtel pschichtel force-pushed the feature/gateway-provisioner-chart branch 4 times, most recently from 058fa58 to 3f0d471 Compare September 1, 2025 18:27
@pschichtel
Copy link
Member Author

I have an internal fork deployed to a cluster in together with the contour chart (with manageCRDs: false)

@pschichtel pschichtel force-pushed the feature/gateway-provisioner-chart branch from 3f0d471 to 9ac1fb2 Compare September 1, 2025 18:40
Copy link
Member

@deepy deepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to freshen up a bit more on subcharts and take a second pass, but it looks good and I think this is something we absolutely want to have

@pschichtel pschichtel force-pushed the feature/gateway-provisioner-chart branch 3 times, most recently from 598cede to 1ded30c Compare October 1, 2025 22:42
@pschichtel pschichtel force-pushed the feature/gateway-provisioner-chart branch from 1ded30c to cff4b45 Compare October 1, 2025 22:42
@tsaarni
Copy link
Member

tsaarni commented Nov 29, 2025

I’m curious about the community consensus on splitting CRDs from the Contour chart. I’m not an experienced Helm user, so I’m not familiar on the best practices. My assumption is that this would be a breaking change, so it should be done before the Contour Helm chart is set to a stable version.

@pschichtel Would it be possible to separate the contour-gateway-provisioner changes from this PR, so that they can be handled independently of the CRD discussion?

@pschichtel
Copy link
Member Author

@tsaarni This PR is not a breaking change, it just introduces a chart that carries nothing but the CRDs in order to possibly share it with the contour chart in the future. So I don't understand the issue. Also: I have long moved away from contour for technical reasons in my infrastructure, so I won't be investing time here when things are unclear. Anyone else is fine to take over in the meantime.

@tsaarni
Copy link
Member

tsaarni commented Dec 1, 2025

Thanks, @pschichtel, for your response!

This PR is not a breaking change, it just introduces a chart that carries nothing but the CRDs in order to possibly share it with the contour chart in the future. So I don't understand the issue.

While this PR doesn’t remove CRDs from main chart, I think we should avoid duplicating CRDs across multiple charts and instead have them exclusively in the separate CRD chart. If we removed the CRDs from the main chart, that change could be breaking (if done after stable release).

Also: I have long moved away from contour for technical reasons in my infrastructure, so I won't be investing time here when things are unclear.

Understood, and thanks for your contributions so far!

@Sefiris
Copy link

Sefiris commented Dec 1, 2025

While this PR doesn’t remove CRDs from main chart, I think we should avoid duplicating CRDs across multiple charts and instead have them exclusively in the separate CRD chart. If we removed the CRDs from the main chart, that change could be breaking (if done after stable release).

Better to get this over with as soon as possible IMHO, so maybe let's remove this from the chart? since @pschichtel mentioned he would not want to invest more time into it are you okay with me taking over this PR @tsaarni?

@tsaarni
Copy link
Member

tsaarni commented Dec 1, 2025

are you okay with me taking over this PR

Yes absolutely, I created new issue specifically for the CRD chart #21, Thank you @Sefiris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants