-
Notifications
You must be signed in to change notification settings - Fork 6
Introduce contour-crds and contour-gateway-provisioner charts #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Introduce contour-crds and contour-gateway-provisioner charts #4
Conversation
|
I bootstrapped the contour-gateway-provisioner chart using |
058fa58 to
3f0d471
Compare
|
I have an internal fork deployed to a cluster in together with the contour chart (with |
3f0d471 to
9ac1fb2
Compare
deepy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to freshen up a bit more on subcharts and take a second pass, but it looks good and I think this is something we absolutely want to have
598cede to
1ded30c
Compare
Signed-off-by: Phillip Schichtel <[email protected]>
1ded30c to
cff4b45
Compare
|
I’m curious about the community consensus on splitting CRDs from the Contour chart. I’m not an experienced Helm user, so I’m not familiar on the best practices. My assumption is that this would be a breaking change, so it should be done before the Contour Helm chart is set to a stable version. @pschichtel Would it be possible to separate the contour-gateway-provisioner changes from this PR, so that they can be handled independently of the CRD discussion? |
|
@tsaarni This PR is not a breaking change, it just introduces a chart that carries nothing but the CRDs in order to possibly share it with the contour chart in the future. So I don't understand the issue. Also: I have long moved away from contour for technical reasons in my infrastructure, so I won't be investing time here when things are unclear. Anyone else is fine to take over in the meantime. |
|
Thanks, @pschichtel, for your response!
While this PR doesn’t remove CRDs from main chart, I think we should avoid duplicating CRDs across multiple charts and instead have them exclusively in the separate CRD chart. If we removed the CRDs from the main chart, that change could be breaking (if done after stable release).
Understood, and thanks for your contributions so far! |
Better to get this over with as soon as possible IMHO, so maybe let's remove this from the chart? since @pschichtel mentioned he would not want to invest more time into it are you okay with me taking over this PR @tsaarni? |
As suggested in #3 a PR that introduces a chart for the gateway provisioner. I needed to build this anyway, because we standardized on deployments using helm. As a preparation I've also added a chart for the CRDs, which could be pulled by the main contour chart as well.
What I considered, but didn't do in this PR:
oci://docker.io/envoyproxy/gateway-crds-helm