Skip to content

fix SMTP VRFY returning 502 by migrating to emersion/go-smtp#1376

Open
Mzack9999 wants to merge 2 commits into
devfrom
991-smtp-vrfy
Open

fix SMTP VRFY returning 502 by migrating to emersion/go-smtp#1376
Mzack9999 wants to merge 2 commits into
devfrom
991-smtp-vrfy

Conversation

@Mzack9999
Copy link
Copy Markdown
Member

Summary

  • Replace git.mills.io/prologic/smtpd with github.com/emersion/go-smtp, which responds to VRFY with 252 instead of 502 Command not implemented
  • Clients such as curl that run VRFY before MAIL/DATA can now continue the SMTP session instead of aborting
  • Add smtp_backend.go implementing the emersion Backend/Session while keeping existing interaction storage behavior on DATA

Closes #991

Test plan

  • go test ./pkg/server/ -run TestSMTPVRFY -v
  • go test ./pkg/server/
  • go build ./...

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c76e16e7-bb76-48ea-a009-8e108208b530

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 991-smtp-vrfy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mzack9999 Mzack9999 requested a review from dogancanbakir May 20, 2026 05:02
@Mzack9999 Mzack9999 linked an issue May 21, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SMTP missing command: VRFY

1 participant