optional redis storage backend so multiple instances can share state#1377
Open
Mzack9999 wants to merge 2 commits into
Open
optional redis storage backend so multiple instances can share state#1377Mzack9999 wants to merge 2 commits into
Mzack9999 wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1267. Lets you run multiple interactsh-server instances behind a load balancer sharing one Redis. Pass
--redis-url(and optionally--redis-prefix) to enable; everything else stays exactly as it is today, the existing in-memory/LevelDB path is left alone.The new backend plugs into the same
storage.Storageinterface, uses hash-tagged keys so it also works on Redis Cluster, and runs the per-consumer read/evict/trim ops as atomic Lua scripts. TTL respects the existing sliding/fixed eviction strategies.Tested with miniredis-based unit tests, an opt-in integration suite against a real Redis, and a two-instance smoke harness under
deploy/redis-test/that registers viapkg/clienton instance A, fires an HTTP hit at B, and confirms it polls back from A.ACME certs and per-instance metrics still live on each box, that's a separate problem.
Closes #1267