Skip to content

stop leaking host fingerprint in client correlation id#1378

Merged
Mzack9999 merged 1 commit into
devfrom
1349-anonymous-correlation-id
May 23, 2026
Merged

stop leaking host fingerprint in client correlation id#1378
Mzack9999 merged 1 commit into
devfrom
1349-anonymous-correlation-id

Conversation

@Mzack9999

Copy link
Copy Markdown
Member

Plain xid.New() derives its machine bytes from md5(hostname), which rides along on every OAST callback and lets the target (or third-party telemetry like GreyNoise) correlate scans back to the same operator. Keeps the timestamp prefix so format/sortability/server-side validation stay identical.

Closes #1349

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 464026bf-d361-4c19-9385-254a0ca47540

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1349-anonymous-correlation-id

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mzack9999 Mzack9999 self-assigned this May 21, 2026
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label May 21, 2026
@Mzack9999 Mzack9999 linked an issue May 21, 2026 that may be closed by this pull request

@jentfoo jentfoo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for reconsidering this issue

@Mzack9999 Mzack9999 merged commit b25fc58 into dev May 23, 2026
9 checks passed
@Mzack9999 Mzack9999 deleted the 1349-anonymous-correlation-id branch May 23, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement Most issues will probably ask for additions or changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concerns on XID Usage and Truncation

2 participants