ci: disable unused container_description workflow#1940
Open
sibasispadhi wants to merge 1 commit into
Open
Conversation
Fixes prometheus#1938 This workflow was added via automated sync (PrometheusBot) in May 2024 but has never worked because client_golang is a library, not a containerized service that publishes container images. The workflow fails because: - DOCKER_IMAGE_NAME is not defined in the Makefile - The 'docker-repo-name' Makefile target doesn't exist - The only Dockerfile is for building local examples, not distribution This change disables the workflow (rather than deleting) to: - Stop failing CI runs that have occurred since May 2024 - Document why client_golang doesn't need container image publishing - Prevent future automated syncs from re-enabling it - Preserve the file for historical context - Allow manual trigger if ever needed in the future The workflow trigger is changed from 'push' to 'workflow_dispatch' (manual only) with detailed comments explaining the situation and jobs that exit with an error if accidentally triggered. Signed-off-by: Sibasis Padhi <sibasis.padhi@gmail.com>
sibasispadhi
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
Author
|
@vesari per my analysis, I thought its best to disable the feature. Kindly take a look on the changes, and let me know what is your thought process on same or any further changes needed. |
Member
|
@vesari could you take a look at it? @sibasispadhi This needs a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1938
This workflow was added via automated sync (PrometheusBot) in May 2024 but has never worked because client_golang is a library, not a containerized service that publishes container images.
The workflow fails because:
This change disables the workflow (rather than deleting) to:
The workflow trigger is changed from 'push' to 'workflow_dispatch' (manual only) with detailed comments explaining the situation and jobs that exit with an error if accidentally triggered.