fix: potential race conditions for metrics with no label constraints#1952
Open
denopink wants to merge 2 commits into
Open
fix: potential race conditions for metrics with no label constraints#1952denopink wants to merge 2 commits into
denopink wants to merge 2 commits into
Conversation
denopink
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
denopink
force-pushed
the
patch-1
branch
3 times, most recently
from
ddc232d to
c81a28f
Compare
Author
|
closes 1429 |
denopink
changed the title
kakkoyun
reviewed
Feb 17, 2026
kakkoyun
left a comment
kakkoyun
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution.
I would really appreciate if you could a test to actually replicate the reported race condition, to make sure we won't have any regressions in the future.
- fix: potential race conditions for metrics with no label constraints - Clone labels and label values in `func constrainLabels` and `func constrainLabels` - fix for prometheus#1951 and prometheus#1429 Signed-off-by: Owen Cabalceta <denopink@gmail.com>
Author
Of course, I'll add it after work today or tomorrow morning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
func constrainLabelsandfunc constrainLabels