fix metric vec label input aliasing#2019
Closed
Saithej2k wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Saithej2k <saithej2003@gmail.com>
Member
|
Thanks but we prefer performance vs making it ultra safe for all cases. However some commentary would be useful. See #1951 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Labelsmaps whenMetricVechas no label constraintsGetMetricWithLabelValuespathWhy
When no label constraints are configured,
constrainLabelsandconstrainLabelValuesreturned the caller-owned map or slice directly.MetricVechashes those values first and can then read the same caller-owned input again while creating or matching a metric. If the caller mutates that input concurrently, the internal reads can race and can associate the hash with mutated label values.Fixes #1951.
Validation
go test -race ./prometheus -run 'TestMetricVecGetMetricWith.*Copies' -count=1go test -race ./prometheus -run 'TestMetricVec' -count=1I also tried
go test -race ./prometheus -count=1, but my local Go runtime metrics differed from the checked-in Go collector fixtures, causing unrelatedgo_collector_latest_test.gofailures.