Add [[nodiscard]] to const message field accessors.
#24471
Draft
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers logically constant APIs (similar to the guidance in https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2024/p3122r1.html) where ignoring the return value likely indicates an omission on the part of the caller or a call that can be cleaned up. For example: my_message.mutable_child().grandchild() Creates a child instance but grandchild() is a no-op. mutable_grandchild() may have been intended. PiperOrigin-RevId: 788578034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add [[nodiscard]] to
constmessage field accessors.This covers logically constant APIs (similar to the guidance in
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2024/p3122r1.html) where
ignoring the return value likely indicates an omission on the part of the
caller or a call that can be cleaned up.
For example:
my_message.mutable_child().grandchild()
Creates a child instance but grandchild() is a no-op. mutable_grandchild() may
have been intended.