Skip to content

Fixing map deserialization when header name or value is not a valid UTF8 string #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aqua777 wants to merge 1 commit into from
Closed

Fixing map deserialization when header name or value is not a valid UTF8 string #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/hostcalls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,8 +1188,8 @@ mod utils {
let value = bytes[p..p + size].to_vec();
p += size + 1;
map.push((
String::from_utf8(key).unwrap(),
String::from_utf8(value).unwrap(),
String::from_utf8(key).unwrap_or(String::from("?")),
String::from_utf8(value).unwrap_or(String::from("?")),

@PiotrSikora PiotrSikora Feb 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wrong "solution" - it changes panic to a silently corrupted data (which I could argue is even worse), and it doesn't actually solve the underlying problem (UTF-8 strings are wrong the type to use for HTTP field values).

If you want to return "?", then _bytes() variants provide an escape hatch and allow converting opaque bytes to other types inside plugins and not in the SDK. Those variants have been available for years.

However, the proper solution is to use the appropriate type for HTTP field values, see: #287 (reviews welcome!).

));
}
map
Expand All @@ -1211,7 +1211,7 @@ mod utils {
u32::from_le_bytes(<[u8; 4]>::try_from(&bytes[s + 4..s + 8]).unwrap()) as usize;
let value = bytes[p..p + size].to_vec();
p += size + 1;
map.push((String::from_utf8(key).unwrap(), value));
map.push((String::from_utf8(key).unwrap_or(String::from("?")), value));
}
map
}
Expand Down