refactor: Noteコンポーネントの責務を分割した - #867
Merged
Merged
Conversation
MikuroXina
approved these changes
Sep 6, 2026
MikuroXina
left a comment
MikuroXina
left a comment
Contributor
There was a problem hiding this comment.
現状は "👍" のリアクションしかないので問題ないですが潜在的なバグとして, リアクションを取り消す API の方に指定する絵文字の項目が無い (クエリで最初に見つかった 1 つを消している?) ので消そうとしたリアクションと違うリアクションが消えたりしそうです. API の定義から直さないといけなさそうです.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #784 (一部)
概要
Noteコンポーネントを以下のように分割しましたNoteAuthor: アバター、表示名NoteContent: 本文/CW付き本文の表示NoteActions: リノートとリアクションのボタン部品useReactionフックに分割.types.tsが微妙に変なファイル名になっているけどディレクトリに分けるほどではないのでこうしています