Skip to content

refactor: 削除イベントを発行するようにした - #1840

Open
laminne wants to merge 3 commits into
mainfrom
chore/1836-delete-domain-events
Open

refactor: 削除イベントを発行するようにした#1840
laminne wants to merge 3 commits into
mainfrom
chore/1836-delete-domain-events

Conversation

@laminne

@laminne laminne commented Sep 11, 2026

Copy link
Copy Markdown
Member

close #1836

What does this PR do?

  • setDeletedAtをdeprecatedにし、deleteメソッドに処理を移植
  • setDeletedAtのないモデルはdeleteメソッドを新設

Additional information

  • 感想: イベントが発行されるかのテスト、毎回書くと面倒なのでもう少し良くしたい気もする(アイデアはない)

@laminne laminne self-assigned this Sep 11, 2026
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.65%. Comparing base (50d7dc2) to head (faac3b1).

Files with missing lines Patch % Lines
pkg/accounts/model/follow.ts 33.33% 2 Missing ⚠️
pkg/notes/model/directNote.ts 71.42% 2 Missing ⚠️
pkg/notes/model/note.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
+ Coverage   47.36%   47.65%   +0.28%     
==========================================
  Files         171      171              
  Lines        5882     5901      +19     
  Branches      886      891       +5     
==========================================
+ Hits         2786     2812      +26     
+ Misses       3096     3089       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: 削除イベントを発行するdeleteメソッドをドメインモデルに追加する

1 participant