Skip to content

fix(export): honest AADL static-export fallback + embed source (REQ-273, #468)#734

Merged
avrabe merged 1 commit into
mainfrom
fix/req-273-aadl-static-export
Jul 23, 2026
Merged

fix(export): honest AADL static-export fallback + embed source (REQ-273, #468)#734
avrabe merged 1 commit into
mainfrom
fix/req-273-aadl-static-export

Conversation

@avrabe

@avrabe avrabe commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

REQ-273 / #468 — AADL diagrams in the static compliance export

A static export has no rivet serve JS to fill the .aadl-diagram placeholder, so the perpetual "Loading AADL diagram…" read as a hung/broken report. A prior fix (REQ-200) replaced that text post-hoc in the export wrappers; this fixes it at the render source and embeds the AADL source:

  • document.rs (render_to_html) and render/artifacts.rs now emit an honest placeholder — text true in both modes (serve replaces the container with the SVG on success; a static bundle keeps it) — plus the raw AADL in a collapsible <details>, so a static compliance report shows the architecture textually instead of a dead spinner. The post-hoc string-replacements become harmless no-ops (old string no longer emitted).

The interactive inline SVG still depends on a published spar-wasm asset (cross-repo, spar#259build.rs ships a stub); that remains for when spar publishes the browser bundle. This ships the unblocked user-visible fix.

Also files v0.31 UX backlog (customer requests)

  • REQ-274 test-result trace collapsible tree view (fold/expand, serve + export) — reuses the existing collapsible_tree() over the already-tree-shaped ResultTraceNode.
  • REQ-275 human tag filter — select all / unselect all / filter box.
  • REQ-276 color-contrast audit — fix white-on-light-grey to WCAG AA.

Verified

document AADL unit test + export_html #468 test pass (1073 pages); clippy clean; rivet validate + docs check PASS.

Fixes: REQ-273 · Refs: REQ-274, REQ-275, REQ-276

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

📐 Rivet artifact delta

Change Count
Added 3
Removed 0
Modified 1
Downstream impacted (depth ≤ 5) 0

Graph

graph LR
  REQ_273["REQ-273"]:::modified
  REQ_274["REQ-274"]:::added
  REQ_275["REQ-275"]:::added
  REQ_276["REQ-276"]:::added
  classDef added fill:#d4edda,stroke:#28a745,color:#155724
  classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
  classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
  classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Loading
Added
  • REQ-274
  • REQ-275
  • REQ-276
Modified
ID Changes
REQ-273

📎 Full HTML dashboard attached as workflow artifact rivet-delta-pr-734download from the workflow run.

Posted by rivet-delta workflow. The graph shows only changed artifacts; open the HTML dashboard (above) for full context.

…73, #468)

A static compliance export has no `rivet serve` JS to fill the `.aadl-diagram`
placeholder. The perpetual "Loading AADL diagram..." read as a hung/broken
report (#468). A prior fix (REQ-200) already replaced that TEXT post-hoc in the
export wrappers; this fixes it at the render SOURCE and goes further — it
embeds the raw AADL source:

- document.rs (render_to_html) and render/artifacts.rs now emit an honest
  placeholder — text true in both modes (serve replaces the container with the
  SVG on success; a static bundle keeps it) — PLUS the raw AADL in a
  collapsible <details>, so a static compliance report shows the architecture
  textually instead of a dead spinner. The post-hoc string-replacements
  (wrap_page, static_aadl_fallback) become harmless no-ops (the old string is
  no longer emitted).

The interactive inline SVG still depends on a published spar-wasm asset
(cross-repo, spar#259 — build.rs ships a stub); that remains for when spar
publishes the browser bundle. This ships the unblocked user-visible fix.

Also files the v0.31 UX backlog from customer requests (release: v0.31.0):
- REQ-274 test-result trace collapsible tree view (fold/expand, serve+export)
- REQ-275 human tag filter (select all / unselect all / filter box)
- REQ-276 color-contrast audit (fix white-on-light-grey to WCAG AA)

Confirmed: document AADL test + export_html #468 test pass; clippy clean;
rivet validate + docs check PASS.

Fixes: REQ-273
Refs: REQ-274, REQ-275, REQ-276
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@avrabe
avrabe merged commit 77faf5e into main Jul 23, 2026
31 of 32 checks passed
@avrabe
avrabe deleted the fix/req-273-aadl-static-export branch July 23, 2026 13:18
avrabe added a commit that referenced this pull request Jul 23, 2026
#736)

Bumps workspace 0.29.0 -> 0.30.0 (rivet-core, rivet-cli, etch) + vscode-rivet.

v0.30 scope (all implemented + merged, CI-green):
- REQ-268 per-PR wasm-seam CI gate (#732)
- REQ-271 self-hosted runner disk cleanup (#567, #732)
- REQ-272 hosted traceability fallback (#509, #732)
- REQ-273 honest AADL static-export fallback (#468, #734)

Trace: skip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant