Skip to content

Conversation

@CamSoper
Copy link
Contributor

Fixes #16611

@CamSoper CamSoper enabled auto-merge (squash) December 10, 2025 21:22
@claude
Copy link
Contributor

claude bot commented Dec 10, 2025

Documentation Review

I've reviewed PR #16794 which moves the dynamic login credentials CTA from the "Advanced capabilities" section to the "Essential guides" section.

Summary

Approved - This is a clean organizational improvement with no style, grammar, or technical issues.

Review Details

Changed file: content/docs/esc/get-started/_index.md:134-145

The changes are well-executed:

  • The "Dynamic login credentials" link is moved from the Advanced capabilities section to the Essential guides section
  • The "Advanced capabilities" section heading text is updated to accurately reflect the remaining content ("Extend ESC with external secret providers and advanced OIDC configuration")
  • All links are properly formatted and resolve correctly
  • Grammar, spelling, and style comply with STYLE-GUIDE.md
  • Sentence case is used correctly in H3 headings
  • The reorganization makes logical sense - dynamic login credentials via OIDC are indeed an essential ESC capability rather than an advanced one

Observations

The change improves information architecture by promoting a key ESC feature (generating short-lived cloud credentials) to more prominent placement in the getting started guide, which should help users discover this functionality earlier in their ESC journey.


If you need any additional reviews or changes, feel free to mention me (@claude).

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CTA for Dynamic Login Credentials to ESC Get Started documentation

3 participants