-
Notifications
You must be signed in to change notification settings - Fork 258
Native OIDC token exchange docs and blog #16803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Documentation ReviewI've reviewed the changes in this PR. Overall, the content is well-written and follows most style guidelines, but there are several issues that need to be addressed: Critical Issues1. Missing meta image file
2. Missing author profile
3. Incorrect link reference format
4. Duplicate incorrect link reference
Style Issues5. Missing trailing newline
6. Inconsistent capitalization in heading
Content Suggestions7. Blog post readability
8. Example clarity
9. Prerequisites link verification
Documentation GapsAs this blog post announces a significant new feature, I checked for corresponding documentation coverage: ✅ Good coverage: The PR updates the following documentation:
The documentation appears comprehensive and well-integrated. SummaryThe content is well-written and follows most Pulumi style guidelines. The main issues are:
Please address the critical issues before merging. The style suggestions are optional improvements. If you'd like me to help fix any of these issues, mention me (@claude) with your request. |
|
Your site preview for commit c9d6cac is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16803-c9d6cac9.s3-website.us-west-2.amazonaws.com. |
|
Addressed Claude's comments. |
|
Your site preview for commit c6b1b7c is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16803-c6b1b7ca.s3-website.us-west-2.amazonaws.com. |
|
|
||
| ## How it works | ||
|
|
||
| The new `pulumi login` command accepts OIDC tokens directly: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The new `pulumi login` command accepts OIDC tokens directly: | |
| The `pulumi login` command now accepts OIDC tokens directly: |
pulumi login is not a new command
This PR updates docs and adds a blog post about the new native OIDC token exchange capability of the Pulumi CLI introduced here: pulumi/pulumi#20974