(CONT-812) Correct Style/StringConcatenation

Author: chelnak

lib/puppet-strings/markdown/base.rb

@@ -161,15 +161,15 @@ def enums
     # @return [Array] option tag hashes that have a parent parameter_name
     def options_for_param(parameter_name)
       opts_for_p = options.select { |o| o[:parent] == parameter_name } unless options.nil?
-      opts_for_p unless opts_for_p.nil? || opts_for_p.length.zero?
+      opts_for_p unless opts_for_p.nil? || opts_for_p.empty?
     end
 
     # @param parameter_name
     #   parameter name to match to enum tags
     # @return [Array] enum tag hashes that have a parent parameter_name
     def enums_for_param(parameter_name)
       enums_for_p = enums.select { |e| e[:parent] == parameter_name } unless enums.nil?
-      enums_for_p unless enums_for_p.nil? || enums_for_p.length.zero?
+      enums_for_p unless enums_for_p.nil? || enums_for_p.empty?
     end
 
     # @return [Hash] any defaults found for the component

lib/puppet-strings/markdown/resource_type.rb

@@ -50,7 +50,7 @@ def parameters
 
     def regex_in_data_type?(data_type)
       m = data_type.match(%r{\w+\[/.*/\]})
-      m unless m.nil? || m.length.zero?
+      m unless m.nil? || m.empty?
     end
   end
 end