Skip to content

fix: expiring ballots at the time of voting #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xNilesh merged 1 commit into from
May 15, 2026
Merged

fix: expiring ballots at the time of voting #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions x/uvalidator/keeper/voting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,27 @@ func (k Keeper) VoteOnBallot(
return ballot, false, false, errors.Wrap(err, "Error while voting on the ballot")
}

// reject votes on ballots whose nominal expiry has passed
currentHeight := sdk.UnwrapSDKContext(ctx).BlockHeight()
if ballot.IsExpired(currentHeight) {
// Transition PENDING ballots to EXPIRED so subsequent reads see the
// canonical status and the secondary indexes stay consistent. Already
// non-PENDING ballots fall through to the Status check below for the
// existing "already X" error message.
if ballot.Status == types.BallotStatus_BALLOT_STATUS_PENDING {
if mErr := k.MarkBallotExpired(ctx, id); mErr != nil {
return ballot, false, isNew, errors.Wrap(mErr, "failed to mark ballot expired during late-vote rejection")
}
k.Logger().Warn("late vote rejected, ballot marked expired",
"ballot_id", id,
"expiry_height", ballot.BlockHeightExpiry,
"current_height", currentHeight,
"voter", voter,
)
return ballot, false, isNew, fmt.Errorf("ballot %s expired at height %d (current %d)", id, ballot.BlockHeightExpiry, currentHeight)
}
}

if ballot.Status != types.BallotStatus_BALLOT_STATUS_PENDING {
k.Logger().Warn("ballot is not in pending state, cannot vote",
"ballot_id", id,
Expand Down
Loading