Repository navigation
SVG: read the width and height auto of an <image> like missing ones - #2183
Open
RavSinghChandan wants to merge 3 commits into
Open
RavSinghChandan wants to merge 3 commits into
RavSinghChandan wants to merge 3 commits into
Conversation
<image width="auto"> failed with ValueError: Unable to parse 'auto' as a length. auto, the initial value in SVG 2, is the size of the image itself, which a missing width or height (0) already gives through size_in_document_units().
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<image width="auto" height="30" href="...">fails withValueError: Unable to parse 'auto' as a length.In SVG 2,
autois the initial value of an<image>'swidthandheight: the size of the image itself, or the one that keeps its ratio with the other side. That is what a missing width or height already gives, as 0, throughsize_in_document_units(), sobuild_image()now readsautolike a missing size.test_svg_image_size_autocoversautofor each side, both sides, uppercase and padded with spaces; it fails without the change.