Repository navigation
SVG: draw nothing for a <use> of an id that is not defined - #2188
Open
RavSinghChandan wants to merge 3 commits into
Open
RavSinghChandan wants to merge 3 commits into
RavSinghChandan wants to merge 3 commits into
Conversation
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matplotlib charts in the RapidFuzz documentation (
docs/Usage/img/*.svg, 18 files) were minified, and the glyph of the space character was dropped while the<use xlink:href="#AG"/>that place it were kept.pdf.image()fails on all of them:Browsers draw nothing for such a
<use>and render the rest of the chart, which here only loses the spaces between words.build_xref()now logs a warning ("Ignoring of nonexistent ref id #AG") and returns the empty group, as it already does for a<use>of a hidden element. A<use>without any href still raises, astest_bad_xrefchecks.This changes
test_missing_xref, which expected theValueError: it now checks the warning, that the<use>draws nothing and that a shape after it is still drawn; it fails without the change. All 18 RapidFuzz charts now render. Changelog entry under 2.9.1 / Fixed.