Repository navigation
Drop Apple bitmap tables when subsetting a font - #2192
Open
RavSinghChandan wants to merge 2 commits into
Open
RavSinghChandan wants to merge 2 commits into
RavSinghChandan wants to merge 2 commits into
Conversation
# Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
Geneva.ttforCochin.ttcof macOS,add_font()works butoutput()fails while subsetting the font:fontTools cannot read their
bloctable, Apple's bitmap location table, when the subsetter loads it. The subsetter already dropsEBDT,EBLCandEBSC, since bitmap glyphs are not used in a PDF, but notbdatandbloc, the Apple tables they correspond to. They are now in the samedrop_tableslist.test_add_font_with_apple_bitmap_tablesadds unreadableblocandbdattables to DejaVuSans at run time and outputs text with it; it fails on master with the samestruct.error. Changelog entry under 2.9.1 / Fixed.