Open
Conversation
kbattocchi
approved these changes
Mar 26, 2026
Member
kbattocchi
left a comment
kbattocchi
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Signed-off-by: Michael Ellis <michaelellis003@gmail.com>
Signed-off-by: Michael Ellis <michaelellis003@gmail.com>
kbattocchi
force-pushed
the
fix-drtester-dataframe
branch
from
bdabd7c to
fdcc2f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRTester.fit_nuisance fails when passed pandas DataFrames because fit_nuisance_cv uses numpy-style integer array indexing (X[train]) with the index arrays from StratifiedKFold.split(). Pandas interprets these as column selection, causing a KeyError.
This adds input conversion at the top of fit_nuisance using check_input_arrays, consistent with how other estimators in the package handle this (e.g., _OrthoLearner.fit).
Fixes #852