fix: align _validate_allowed type check with _validate_forbidden#637
Open
gaoflow wants to merge 1 commit into
Open
fix: align _validate_allowed type check with _validate_forbidden#637gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
_validate_allowed used Iterable (which includes Mapping) while _validate_forbidden used Sequence (which excludes Mapping). This caused 'allowed' to iterate over dict keys instead of checking the dict as a single value, producing inconsistent results between the two rules. Change _validate_allowed from Iterable to Sequence to match _validate_forbidden, so both rules treat dict and set values as single values and only iterate over sequence elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_validate_allowedusedIterablefor its instance check while_validate_forbiddenusedSequence. SinceMapping(dict) is anIterablebut not aSequence, this caused inconsistent behavior:allowed: [{"key": "val"}]with value{"key": "val"}: iterated over dict keys, found "key" not in[{"key": "val"}], and incorrectly rejected the value.forbidden: [{"key": "val"}]with value{"key": "val"}: correctly checked the dict as a whole value.Fix
Changed
_validate_allowedfrom usingIterabletoSequence(matching_validate_forbidden), so both rules treat dict and set values as single values and only iterate over sequence elements.Changes
cerberus/validator.py: one line changed (Iterable->Sequencein_validate_allowed)cerberus/tests/test_validation.py: added test covering the inconsistency