Skip to content

Comments

[Fix] ClusterExecutor fix time when crashing#925

Merged
jan-janssen merged 2 commits intomainfrom
clusterexecutor_time
Feb 16, 2026
Merged

[Fix] ClusterExecutor fix time when crashing#925
jan-janssen merged 2 commits intomainfrom
clusterexecutor_time

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Feb 16, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved accuracy of task execution time measurements to ensure consistent timing calculations across all execution paths, including error scenarios.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The change repositions the start time initialization in backend_execute_task_in_file from inside the try block to the function's entry point, ensuring runtime measurement captures the entire execution including exception scenarios.

Changes

Cohort / File(s) Summary
Timing Initialization
src/executorlib/task_scheduler/file/backend.py
Moved time_start = time.time() assignment from inside try block to function start for consistent runtime measurement across all execution paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A clock ticks sooner, measuring true,
From start to finish, nothing askew,
No exception shall hide the time,
Every path synchronized in perfect rhyme!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[Fix] ClusterExecutor fix time when crashing' directly relates to the main change: moving time_start earlier to ensure accurate runtime measurement even when exceptions occur.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch clusterexecutor_time

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.83%. Comparing base (c73022b) to head (19d5b10).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          38       38           
  Lines        1963     1963           
=======================================
  Hits         1842     1842           
  Misses        121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen merged commit 8871044 into main Feb 16, 2026
62 of 63 checks passed
@jan-janssen jan-janssen deleted the clusterexecutor_time branch February 16, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant