Skip to content

Comments

Catch while node output#151

Merged
liamhuber merged 1 commit intoparsing_recipesfrom
catch-reassigned-symbols
Feb 20, 2026
Merged

Catch while node output#151
liamhuber merged 1 commit intoparsing_recipesfrom
catch-reassigned-symbols

Conversation

@liamhuber
Copy link
Member

That is not actually looped as input, but is nonetheless updated at each cycle.

I.e.

def wf(x, bound, y):
    while my_condition(x, bound):
        x = my_add(x, x)
        y = identity(x)
    return y

Which is now in the test cases.

I caught this edge case going through what issues can be closed when #108 is merged and found the counter example in #91 🙏

That is not actually looped as input, but is nonetheless updated at each cycle.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/flowrep/catch-reassigned-symbols

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.93%. Comparing base (4cae32b) to head (55fa88f).
⚠️ Report is 2 commits behind head on parsing_recipes.

Additional details and impacted files
@@               Coverage Diff                @@
##           parsing_recipes     #151   +/-   ##
================================================
  Coverage            98.93%   98.93%           
================================================
  Files                   27       27           
  Lines                 1879     1882    +3     
================================================
+ Hits                  1859     1862    +3     
  Misses                  20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liamhuber liamhuber mentioned this pull request Feb 20, 2026
@liamhuber liamhuber merged commit 3840e59 into parsing_recipes Feb 20, 2026
20 checks passed
@liamhuber liamhuber deleted the catch-reassigned-symbols branch February 20, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant