Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # tests/test_potential.py
for more information, see https://pre-commit.ci
…ction # Conflicts: # tests/test_compatibility_file.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o lammps_function
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jan-janssen
force-pushed
the
lammps_function_water
branch
from
2354587 to
fcedda5
Compare
for more information, see https://pre-commit.ci
# Conflicts: # pyiron_lammps/compatibility/file.py # pyiron_lammps/compatibility/structure.py # tests/test_compatibility_file.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
- Coverage 92.75% 89.52% -3.24%
==========================================
Files 8 9 +1
Lines 980 1136 +156
==========================================
+ Hits 909 1017 +108
- Misses 71 119 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
# Conflicts: # pyiron_lammps/compatibility/file.py
for more information, see https://pre-commit.ci
…ps_function_water # Conflicts: # tests/test_water_compatibility_file.py
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if there is something which can be transferred from
pyiron_core:https://github.com/pyiron/pyiron_core/blob/caff3b7398ca7bcbb062bf6678dc68792e572943/pyiron_core/pyiron_nodes/atomistic/engine/lammps.py