Add liquid XP by OhmV-IR · Pull Request #809 · pylonmc/pylon

OhmV-IR · 2026-03-01T18:03:49Z

Closes #745 ,
Closes #744 ,
Closes #743

You get liquid XP from vanilla XP by sneaking on top of the XP drain, note that this is done at a slightly net gain rate to make this system worthwhile
Liquid XP can be remade into vanilla XP either through the experience fountain which drops it as vanilla XP orbs or via the hydraulic / diesel experience bottlers
1mB of liquid XP = 1 vanilla XP

Intybyte

Github didn't link some of the issues bw

# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonItems.java # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml # src/main/resources/researches.yml

LordIdra

Missing research key

Research is far too expensive - this is most useful early-ish game when you want to save XP. May I suggest 10 points?

Research should probably be called something other than 'experience production' given you are not actually producing XP ('Experience Liquefaction'?)

I suggest the drain, fountain, and fountain spout go in Fluid Machines as there are machines related to XP which are in other categories (i.e. bottler and probably more in future), so having a separate category for XP stuff is a bit confusing

I think the recipes for XP stuff are also too expensive as this is very useful early-game to conserve XP - I would suggest a very cheap recipe here, especially for drain

Diesel/hydraulic bottlers look strange as there's nothing connecting the connection point to the brewing stand

Diesel/hydraulic bottler multiblock is quite weird... might I suggest just having an input hatch underneath instead?

As discussed the drain conversion ratio should probably be nuked

Drain appears to require shimmer pedestals (???)

Experience liquid should probably be green to reflect XP orb color - this is how mods do it

OhmV-IR · 2026-04-11T02:57:32Z

My todo list of your comments (so I can remember what I've done)

Fix research points amount
Rename research
Move to fluid machines
Adjust recipes to be cheaper
Fix diesel / hydraulic bottlers multiblock look
Drain shouldn't require shimmer pedestals
Experience liquid should be green
Deal with CW comments

LordIdra · 2026-04-12T14:52:13Z

+    lore: |-
+      <arrow> Drains experience when you <insn>Sneak</insn> on top of the block
+      <arrow> <attr>Experience drain amount:</attr> %xp-drain-rate%
+      <arrow> <attr>Experience conversion ratio:</attr> %conversion-ratio%


LordIdra · 2026-04-12T14:52:57Z

+xp-drain-period-ticks: 5
+xp-drain-amount: 10
+xp-buffer-amount: 250
+conversion-ratio: 1.0 # How much liquid xp for each vanilla XP. If this is more than 1, the machine is profitable


LordIdra · 2026-04-12T14:53:31Z

+  experience_fountain:
+    name: "Experience Fountain"
+    lore: |-
+      <arrow> Produces experience when connected to a liquid xp source
+      <arrow> <attr>Experience production rate:</attr> %production-rate%


Missing multiblock components lore

LordIdra · 2026-04-12T14:55:08Z

+  experience_drain:
+    name: "Experience Drain"
+    lore: |-
+      <arrow> Drains experience when you <insn>Sneak</insn> on top of the block


Idra Lore Nitpick™: Maybe better as <arrow> <insn>Sneak</insn> while standing on top to liquefy your experience

LordIdra · 2026-04-12T14:56:32Z

+    @Override
+    public @NotNull Map<@NotNull Vector3i, @NotNull MultiblockComponent> getComponents() {
+        return Map.of(
+                new Vector3i(3, 0, 0), PEDESTAL_COMPONENT,
+                new Vector3i(2, 0, 2), PEDESTAL_COMPONENT,
+                new Vector3i(0, 0, 3), PEDESTAL_COMPONENT,
+                new Vector3i(-2, 0, 2), PEDESTAL_COMPONENT,
+                new Vector3i(-3, 0, 0), PEDESTAL_COMPONENT,
+                new Vector3i(-2, 0, -2), PEDESTAL_COMPONENT,
+                new Vector3i(0, 0, -3), PEDESTAL_COMPONENT,
+                new Vector3i(2, 0, -2), PEDESTAL_COMPONENT
+        );
+    }


Is there any reason for this to be a multiblock? It seems a bit illogical to me especially as the other blocks are not magic components and serve no functional purpose

LordIdra · 2026-04-12T15:11:45Z

+    public @Nullable FluidInputHatch getFluidInputHatch() {
+        Vector relativeLocation = Vector.fromJOML(RebarUtils.rotateVectorToFace(new Vector3i(2, 1, 0), getFacing()));
+        Location inputHatchLocation = getBlock().getLocation().add(relativeLocation);
+        return BlockStorage.getAs(FluidInputHatch.class, inputHatchLocation);
+    }
+
+    public @Nullable FluidInputHatch getExperienceInputHatch() {
+        Vector relativeLocation = Vector.fromJOML(RebarUtils.rotateVectorToFace(new Vector3i(0, 2, 0), getFacing()));
+        Location hatchLoc = getBlock().getLocation().add(relativeLocation);
+        return BlockStorage.getAs(FluidInputHatch.class, hatchLoc);
+    }
+
+    public @Nullable FluidOutputHatch getFluidOutputHatch() {
+        Vector relativeLocation = Vector.fromJOML(RebarUtils.rotateVectorToFace(new Vector3i(-2, 1, 0), getFacing()));
+        Location inputHatchLocation = getBlock().getLocation().add(relativeLocation);
+        return BlockStorage.getAs(FluidOutputHatch.class, inputHatchLocation);
+    }


I have since added nice util methods for this - see how biorefinery does it for example

LordIdra · 2026-04-12T15:12:33Z

+        if (inputHatch == null || xpHatch == null) {
+            return;
+        }
+        if(outputFluid != null && outputHatch == null){
+            return;
+        }
+        if (!inputHatch.hasFluid(inputFluid) || !xpHatch.hasFluid(PylonFluids.LIQUID_XP)) {
+            return;
+        }
+        if (inputHatch.fluidAmount(inputFluid) < inputFluidConsumptionRate * bottleProductionRateTicks / 20) {
+            return;
+        }
+        if(xpHatch.fluidAmount(PylonFluids.LIQUID_XP) < XP_AMOUNT){
+            return;
+        }
+        if (bottleInput.getItem(0) == null || bottleInput.getItem(0).getType() != Material.GLASS_BOTTLE) {
+            return;
+        }
+        RebarItem bottleOutputItem = RebarItem.fromStack(bottleOutput.getItem(0));
+        if (bottleOutputItem != null && (!bottleOutputItem.getKey().equals(PylonKeys.LIQUID_XP_BOTTLE) || bottleOutputItem.getStack().getAmount() == bottleOutputItem.getStack().getMaxStackSize())) {
+            return;
+        }
+        if (outputFluid != null && outputHatch.fluidSpaceRemaining(outputFluid) < fluidOutputProductionRate * bottleProductionRateTicks / 20) {
+            return;
+        }


I would collapse some of these for readability since there are so many

LordIdra · 2026-04-12T15:13:10Z

+    @Override
+    public @NotNull Gui createGui() {
+        return Gui.builder()
+                .setStructure(
+                        "# # I # # # O # #",
+                        "# # i # # # o # #",
+                        "# # I # # # O # #"
+                )
+                .addIngredient('#', GuiItems.background())
+                .addIngredient('I', GuiItems.input())
+                .addIngredient('O', GuiItems.output())
+                .addIngredient('i', bottleInput)
+                .addIngredient('o', bottleOutput)
+                .build();
+    }


Missing an indication of progress

LordIdra · 2026-04-12T15:14:53Z

+        if(xpInputHatch != null && xpInputHatch.hasFluid(PylonFluids.LIQUID_XP)) {
+            return new WailaDisplay(getDefaultWailaTranslationKey().arguments(RebarArgument.of("xpbar", PylonUtils.createFluidAmountBar(
+                    xpInputHatch.fluidAmount(PylonFluids.LIQUID_XP),
+                    xpInputHatch.fluidCapacity(PylonFluids.LIQUID_XP),
+                    20,
+                    TextColor.fromHexString("#1dc420")
+            ))));
+        } else {
+            return new WailaDisplay(getDefaultWailaTranslationKey().arguments(RebarArgument.of("xpbar", PylonUtils.createFluidAmountBar(
+                    0,
+                    0,
+                    20,
+                    TextColor.fromHexString("#1dc420")
+            ))));
+        }


I would show a recipe progress bar instead of the amount of liquid XP here as there are multiple fluid inputs/outputs so it can be a bit confusing, and breaks convention with other machines

LordIdra · 2026-04-12T15:17:36Z

+        Map<@NotNull Vector3i, @NotNull MultiblockComponent> map = new HashMap<>();
+        map.put(new Vector3i(0, 1, 0), new RebarSimpleMultiblock.VanillaMultiblockComponent(Material.IRON_BARS));
+        map.put(new Vector3i(0, 2, 0), new RebarSimpleMultiblock.RebarMultiblockComponent(PylonKeys.FLUID_INPUT_HATCH));
+        map.put(new Vector3i(1, 1, 0), new RebarSimpleMultiblock.VanillaMultiblockComponent(Material.IRON_BARS));
+        map.put(new Vector3i(1, 0, 0), new RebarSimpleMultiblock.VanillaMultiblockComponent(Material.IRON_BARS));
+        map.put(new Vector3i(2, 1, 0), new RebarSimpleMultiblock.RebarMultiblockComponent(PylonKeys.FLUID_INPUT_HATCH));
+        if(outputFluid != null){
+        map.put(new Vector3i(-1, 1, 0), new RebarSimpleMultiblock.VanillaMultiblockComponent(Material.IRON_BARS));
+        map.put(new Vector3i(-1, 0, 0), new RebarSimpleMultiblock.VanillaMultiblockComponent(Material.IRON_BARS));
+        map.put(new Vector3i(-2, 1, 0), new RebarSimpleMultiblock.RebarMultiblockComponent(PylonKeys.FLUID_OUTPUT_HATCH));
+        }


Have to say I'm not a fan of this multiblock aesthetically... May I suggest something like the following?

(Lapis block and iron support beams)

Intybyte requested changes Mar 4, 2026

View reviewed changes

OhmV-IR added 2 commits March 10, 2026 19:09

the grand commit

e35bb5d

# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonItems.java # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml # src/main/resources/researches.yml

pr comments

fe0fb2e

OhmV-IR force-pushed the add-liquid-xp branch from 67b263b to fe0fb2e Compare March 10, 2026 23:09

compile

34176f9

LordIdra reviewed Mar 11, 2026

View reviewed changes

Comment thread src/main/resources/lang/en.yml

OhmV-IR added 3 commits April 10, 2026 22:36

Merge branch 'master' into add-liquid-xp

e871eae

move to fluid machines and fix research tkey

35343c3

nuke the ratio

00e4c06

OhmV-IR added 6 commits April 11, 2026 22:50

make experience fountain and drain cheaper

bbea585

Merge branch 'master' into add-liquid-xp

c300932

make xp drain use regular pedestals

8b3bde2

actually why not just cobble wall

0ff15bb

change xp fluid color to green

ef088dc

implement the last fixes

ba10a5f

OhmV-IR requested a review from LordIdra April 12, 2026 12:47

LordIdra requested changes Apr 12, 2026

View reviewed changes

Conversation

OhmV-IR commented Mar 1, 2026 • edited by Intybyte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Intybyte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LordIdra left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OhmV-IR commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

OhmV-IR commented Mar 1, 2026 •

edited by Intybyte

Loading

LordIdra left a comment •

edited

Loading

OhmV-IR commented Apr 11, 2026 •

edited

Loading