fix: use Enchantment#description() for MiniMessage enchantment tag#697
Open
ybw0014 wants to merge 1 commit intopylonmc:masterfrom
Open
fix: use Enchantment#description() for MiniMessage enchantment tag#697ybw0014 wants to merge 1 commit intopylonmc:masterfrom
Enchantment#description() for MiniMessage enchantment tag#697ybw0014 wants to merge 1 commit intopylonmc:masterfrom
Conversation
ybw0014
changed the title
Enchantment#description()Enchantment#description() for MiniMessage enchantment tag
Seggan
approved these changes
Apr 11, 2026
Contributor
Author
|
is CI failing matter for this PR? |
Contributor
|
no, just a flaky test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all enchantments have a translation key. Using
Enchantment#translationKey()can cause error if the enchantment description is not translatable (like in RebarMobs, all the Enchantment descriptions are simple text components)