You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ghost blocks and multiblock components have become quite a mess with all the changes that have been made. This PR cleans it up by unifying the multiblock components under a single class (there was never really any good reason for it to be an interface) and adding an abstraction layer (RebarGhostBlockHolder) which separates the ghost block logic from the multiblock logic. The abstraction layer will also allow implementors of RebarMultiblock to spawn their own ghost blocks easily, which was previously very annoying to do. This also unifies handling of mixed multiblock components (rebar/vanilla) which has removed a lot of unnecessary logic.
While this approach is much simpler, it also prevents people from making their own blocks using multiblocks, let's say i am a plugin dev and i want part of it to be done using idk, a Nexo or ItemsAdder block, now i can't add such feature without forking rebar unlike before
While this approach is much simpler, it also prevents people from making their own blocks using multiblocks, let's say i am a plugin dev and i want part of it to be done using idk, a Nexo or ItemsAdder block, now i can't add such feature without forking rebar unlike before
While this approach is much simpler, it also prevents people from making their own blocks using multiblocks, let's say i am a plugin dev and i want part of it to be done using idk, a Nexo or ItemsAdder block, now i can't add such feature without forking rebar unlike before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ghost blocks and multiblock components have become quite a mess with all the changes that have been made. This PR cleans it up by unifying the multiblock components under a single class (there was never really any good reason for it to be an interface) and adding an abstraction layer (
RebarGhostBlockHolder) which separates the ghost block logic from the multiblock logic. The abstraction layer will also allow implementors ofRebarMultiblockto spawn their own ghost blocks easily, which was previously very annoying to do. This also unifies handling of mixed multiblock components (rebar/vanilla) which has removed a lot of unnecessary logic.