feat: add live MDA status line#161
Conversation
(cherry picked from commit eece798c96a0e1b28eed6149e40edb28c4771192)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 81.84% 82.94% +1.10%
==========================================
Files 29 29
Lines 1807 1912 +105
==========================================
+ Hits 1479 1586 +107
+ Misses 328 326 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thanks @gcharvin, this feature is definitely critical. (screenshot for others to see what it adds) It's something we've mocked up in various places in different ways (see pymmcore-plus/pymmcore-widgets#268 and also on our "bleeding edge" feature branch " So, we can just merge this as strictly better than what we already have, but it might undergo visual structural changes. Specifically, I think the global status bar might be a better target for this info. In general with your PRs, if I really like the idea, but had envisioned a different implementation, do you want me to just do it (either as changes to your PR or in a new PR)? or request changes and let you make them? |
|
side note: that one test fail here is genuinely due to this branch... The point is that signals from the core are not emitted synchronously on the main thread, so if you want to make assertions about widget state following some change, you should generally either use |
Summary
Add a small selectable status label to the MDA widget that reports acquisition progress while a sequence is running.
It includes:
Background
This came from using the GUI during TiEclipse MDA runs, where it was hard to tell whether the acquisition was waiting for the next event, still acquiring, paused, or finished.
Validation