Skip to content

fix: "p" at the front of axis order when auto-inserting current stage position#555

Merged
tlambert03 merged 2 commits into
pymmcore-plus:mainfrom
boydcpeters:no-position-insert-front
Apr 8, 2026
Merged

fix: "p" at the front of axis order when auto-inserting current stage position#555
tlambert03 merged 2 commits into
pymmcore-plus:mainfrom
boydcpeters:no-position-insert-front

Conversation

@boydcpeters
Copy link
Copy Markdown
Contributor

Ensure "p" axis is first when auto-inserting current position

When no stage positions are provided, the current position is added automatically and the "p" axis is placed at the front of axis_order.

Closes #550

@boydcpeters boydcpeters changed the title No position insert front Fix axis order when auto-inserting current stage position Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.42%. Comparing base (8c8f76e) to head (bcbdad5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   87.42%   87.42%   -0.01%     
==========================================
  Files         115      115              
  Lines       14081    14079       -2     
==========================================
- Hits        12310    12308       -2     
  Misses       1771     1771              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boydcpeters boydcpeters changed the title Fix axis order when auto-inserting current stage position fix: fix axis order when auto-inserting current stage position Apr 8, 2026
@boydcpeters boydcpeters changed the title fix: fix axis order when auto-inserting current stage position fix: "p" at the front of axis order when auto-inserting current stage position Apr 8, 2026
@tlambert03
Copy link
Copy Markdown
Member

we can't think of any critical reason against this. I think the assumption was just to follow the more likely multi-position pattern, where usually people want to visit each position per time point (as opposed to do the full t at p0 before moving to p1). But of course, that distinction is moot anyway when there's a single position. So it really doesn't matter, and consistency seems better here. thanks @boydcpeters

@tlambert03 tlambert03 merged commit b447718 into pymmcore-plus:main Apr 8, 2026
25 checks passed
@boydcpeters
Copy link
Copy Markdown
Contributor Author

Ahh that makes sense, I can see how this came about when imaging multiple positions, where visiting each position for each timepoint is the more common pattern. Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question about axis-order without provided position

2 participants