fix: call onpropertyChanged with empy device label during mda events#556
Merged
tlambert03 merged 1 commit intoMay 7, 2026
Merged
Conversation
…n_property_changed with an empty device label
Member
|
makes sense! thanks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 115 115
Lines 14091 14093 +2
=======================================
+ Hits 12320 12322 +2
Misses 1771 1771 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i was working with a virtual-microscope, and encountered an error message using an MDA event. After every frame, it was trying to call _on_property_changed with an empty device name after the shutter device was closed. If the device has no label, probably it should skip the call on this signal, since no device state was updated.