Skip to content

fix: call onpropertyChanged with empy device label during mda events#556

Merged
tlambert03 merged 1 commit into
pymmcore-plus:mainfrom
dario-bassi:fix-onpropertyChanged-signals
May 7, 2026
Merged

fix: call onpropertyChanged with empy device label during mda events#556
tlambert03 merged 1 commit into
pymmcore-plus:mainfrom
dario-bassi:fix-onpropertyChanged-signals

Conversation

@dario-bassi
Copy link
Copy Markdown
Contributor

Hi,
i was working with a virtual-microscope, and encountered an error message using an MDA event. After every frame, it was trying to call _on_property_changed with an empty device name after the shutter device was closed. If the device has no label, probably it should skip the call on this signal, since no device state was updated.

…n_property_changed with an empty device label
@tlambert03 tlambert03 changed the title fix:call onpropertyChanged with empy device label during mda events fix: call onpropertyChanged with empy device label during mda events May 7, 2026
@tlambert03
Copy link
Copy Markdown
Member

makes sense! thanks

@tlambert03 tlambert03 enabled auto-merge (squash) May 7, 2026 18:22
@tlambert03 tlambert03 merged commit ade9125 into pymmcore-plus:main May 7, 2026
22 of 23 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.43%. Comparing base (034b7eb) to head (667f297).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         115      115           
  Lines       14091    14093    +2     
=======================================
+ Hits        12320    12322    +2     
  Misses       1771     1771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants