Skip to content

Fix #202: load all unlabeled alerts on Alerts page#233

Open
momocentral wants to merge 1 commit into
mainfrom
fix/202-all-unlabeled-alerts
Open

Fix #202: load all unlabeled alerts on Alerts page#233
momocentral wants to merge 1 commit into
mainfrom
fix/202-all-unlabeled-alerts

Conversation

@momocentral

Copy link
Copy Markdown
Collaborator

Summary

  • Use the paginated unlabeled alerts endpoint from the Alerts page
  • Automatically fetch additional pages until the endpoint is exhausted
  • Flatten all loaded pages before applying the existing current-day filter
  • Add a service test that verifies limit/offset are sent to the API

Fixes #202

Local checks

  • pnpm test src/services/alerts.test.ts src/utils/alerts.test.ts -- --runInBand
  • pnpm run format:check
  • pnpm lint
  • pnpm build

Note: full pnpm test was attempted locally; it hit the known macOS EMFILE/ENFILE limit while importing MUI icons after 95 tests had passed.

@vercel

vercel Bot commented May 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
new-pyro-platform Ready Ready Preview, Comment May 18, 2026 3:53pm

@m-julio

m-julio commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Thanks for your contribution. However this issue is already attributed to another developer and requires changes in the backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Fix alerts page to display all unlabeled alerts for the current day

3 participants