Skip to content

fix: improve downloads (prefer yt-dlp), flexible deps, and update msg#1607

Closed
makise-ui wants to merge 11 commits intopystardust:masterfrom
makise-ui:master
Closed

fix: improve downloads (prefer yt-dlp), flexible deps, and update msg#1607
makise-ui wants to merge 11 commits intopystardust:masterfrom
makise-ui:master

Conversation

@makise-ui
Copy link
Copy Markdown

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

This PR improves the robustness of the download functionality by preferring yt-dlp for both m3u8 and direct mp4 links. It also relaxes the dependency checks so that ani-cli doesn't fail if aria2c is missing but yt-dlp is present. Finally, it improves the error message when self-update fails.

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e (select episode aka -r range selection) works
  • -S select index works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --exit-after-play auto exit after playing works
  • --nextep-countdown countdown to next ep works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

@makise-ui makise-ui requested a review from Derisis13 as a code owner February 24, 2026 18:16
@port19x
Copy link
Copy Markdown
Collaborator

port19x commented Feb 28, 2026

Can you elaborate how yt-dlp is actually better than the current solution?

@makise-ui
Copy link
Copy Markdown
Author

The main reason is that yt-dlp is already used in the script for m3u8 downloads, so it makes sense to also use it for direct mp4 links. This way users only need yt-dlp installed instead of both yt-dlp and aria2c. It also has better retry/error handling built in. aria2c is still kept as a fallback nothing breaks if someone doesn't have yt-dlp

Copy link
Copy Markdown
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x

@port19x
Copy link
Copy Markdown
Collaborator

port19x commented Mar 14, 2026

Current behaviour
Screenshot 2026-03-14 at 13 32 21
Your PR
Screenshot 2026-03-14 at 13 32 37

@port19x port19x closed this Mar 14, 2026
@Derisis13
Copy link
Copy Markdown
Collaborator

Current behaviour Screenshot 2026-03-14 at 13 32 21 Your PR Screenshot 2026-03-14 at 13 32 37

Yeah, Yt-dlp can be very volatile. Plus it straight up refuses to download from some piracy-centered video sharing platforms to avoid piracy accusations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants