fix: improve downloads (prefer yt-dlp), flexible deps, and update msg#1607
Closed
makise-ui wants to merge 11 commits intopystardust:masterfrom
Closed
fix: improve downloads (prefer yt-dlp), flexible deps, and update msg#1607makise-ui wants to merge 11 commits intopystardust:masterfrom
makise-ui wants to merge 11 commits intopystardust:masterfrom
Conversation
Collaborator
|
Can you elaborate how yt-dlp is actually better than the current solution? |
Author
|
The main reason is that yt-dlp is already used in the script for m3u8 downloads, so it makes sense to also use it for direct mp4 links. This way users only need yt-dlp installed instead of both yt-dlp and aria2c. It also has better retry/error handling built in. aria2c is still kept as a fallback nothing breaks if someone doesn't have yt-dlp |
port19x
requested changes
Mar 7, 2026
port19x
approved these changes
Mar 14, 2026
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Pull Request Template
Type of change
Description
This PR improves the robustness of the download functionality by preferring
yt-dlpfor both m3u8 and direct mp4 links. It also relaxes the dependency checks so that ani-cli doesn't fail ifaria2cis missing butyt-dlpis present. Finally, it improves the error message when self-update fails.Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-e(select episode aka -r range selection) works-Sselect index works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--exit-after-playauto exit after playing works--nextep-countdowncountdown to next ep works--duband regular (sub) mode both work-hhelp info is up to date