Implement --debug-mode option to set DEBUG to True prior to run tests#502
Closed
adrysn wants to merge 7 commits intopytest-dev:masterfrom
adrysn:master
Closed
Implement --debug-mode option to set DEBUG to True prior to run tests#502adrysn wants to merge 7 commits intopytest-dev:masterfrom adrysn:master
adrysn wants to merge 7 commits intopytest-dev:masterfrom
adrysn:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
=========================================
+ Coverage 85.74% 85.85% +0.1%
=========================================
Files 32 32
Lines 1614 1626 +12
Branches 140 141 +1
=========================================
+ Hits 1384 1396 +12
Misses 177 177
Partials 53 53
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 91.92% 91.98% +0.05%
==========================================
Files 33 33
Lines 1660 1672 +12
Branches 143 144 +1
==========================================
+ Hits 1526 1538 +12
Misses 95 95
Partials 39 39
Continue to review full report at Codecov.
|
Contributor
|
I would prefer a |
blueyed
suggested changes
Oct 28, 2017
Contributor
blueyed
left a comment
blueyed
left a comment
There was a problem hiding this comment.
See above.
Also needs to be rebased.
blueyed
reviewed
Nov 1, 2017
pytest_django/plugin.py
Outdated
| help='Set DEBUG to true prior to run tests') | ||
| group._addoption('--django-debug', | ||
| action='store_true', dest='debug_mode', default=False, | ||
| help='Set DEBUG to true prior to run tests') |
Contributor
There was a problem hiding this comment.
nitpick (no need to change it already): s/true/True ?!
Author
|
It seems that original pull-request is active again (#463), so it would be appropriate that I close this pull-request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #463 since it has been quite a while after the last discussion in the PR.
I just slightly changed @dulaccc's PR. Changes are:
--django-debugis changed to--debug-modeto follow the naming in Django 1.11 (https://docs.djangoproject.com/en/dev/ref/django-admin/#cmdoption-test-debug-mode).--debug-modeis boolean-basis, not string-basis. For example,pytestruns tests in non-debug mode (DEBUG=False)pytest --debug-moderuns tests in debug mode (DEBUG=True)