Conversation
|
I will edit the changes later, but any comments welcome in the meantime. The RTD build has some error in subtests.rst: |
Seem related to the new We might need to update the pytest highlighter, perhaps @asottile can help? Otherwise we can change from |
c995061 to
2538175
Compare
|
I addressed @nicoddemus's comments and edited the changelog. The other parts of the diff have some problems I need to check. |
|
I can take a look at the highlighter later today probably |
|
I tried to fix regendoc to handle nested directives but my simplistic attempt (fiddling with the |
|
latest pygments-pytest has ~partial support for subtests. at least for now I didn't bother handling all the possible highlighting but just the basic ones to unblock this |
doc/en/getting-started.rst
Outdated
|
|
||
| $ pytest --version | ||
| pytest 8.4.2 | ||
| pytest 8.5.0.dev291+gadb3658f0.d20251105 |
There was a problem hiding this comment.
| pytest 8.5.0.dev291+gadb3658f0.d20251105 | |
| pytest 9.0.0 |
There was a problem hiding this comment.
Hmm I think we have a SETUPTOOLS_SCM_PRETEND_VERSION thing that should have taken care of it. I will check.
There was a problem hiding this comment.
I'm not sure why it doesn't work, I can reproduce that SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST=9.0.0 tox -e regendoc doesn't make it 9.0.0. I changed it manually for now, don't want to go into another rabbit hole :)
There was a problem hiding this comment.
2538175 to
f4b0fd2
Compare
|
@asottile Thanks, updated the bound to pygments-pytest>=2.5.0. |
|
Released to pypi. The "create github release" failed, but too late for here, so I'll merge the PR and handle the github release manually this once... |
|
Failed because git is not installed in the release image (probably the same reason than setuptools_scm fails ?) |
|
I think it rather needs a clone of the repo (I thought it didn't if you specify a pre-existing tag but guess not). |
Done. |
Release 9.0.0 (cherry picked from commit 7b89611)
Created by the prepare release pr workflow.
Once all builds pass and it has been approved by one or more maintainers, start the deploy workflow, using these parameters:
Use workflow from:release-9.0.0.Release version:9.0.0.Or execute on the command line:
gh workflow run deploy.yml -r release-9.0.0 -f version=9.0.0After the workflow has been approved by a core maintainer, the package will be uploaded to PyPI automatically.