Open
Conversation
…es `<w:footnotes>` support.
|
@scanny Any updates on merging footnote support into the library? |
|
Would also be keen to see this one merged in @scanny! |
|
I tested your footnote support, and it works, but it has an issue with large files. Writing 1,200 pages with Python-docx takes only a few seconds, but adding 2,200 footnotes makes it painfully slow. It takes about seven minutes. You can see it getting slower and slower the more footnotes are added. I have not investigated the cause yet but a typical error is to generate lists in loops for indexing in LXML, it is much faster (x100 or more) in large files to use iteratators and methods such as getprevious () and getnext () |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've created footnote support. To the API I added functions: