gh-103997: Remove incorrect statements about -c dedenting#138624
Merged
encukou merged 8 commits intopython:mainfrom Mar 10, 2026
Merged
gh-103997: Remove incorrect statements about -c dedenting#138624encukou merged 8 commits intopython:mainfrom
-c dedenting#138624encukou merged 8 commits intopython:mainfrom
Conversation
picnixz
reviewed
Sep 7, 2025
picnixz
reviewed
Sep 7, 2025
picnixz
reviewed
Sep 7, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
approved these changes
Sep 22, 2025
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
I think it's better that way. Changing the dedent functions to mimic textwrap.dedent exactly is an overkill IMO and not worth the change at the C level.
@AA-Turner I'll let you check English.
encukou
reviewed
Mar 9, 2026
Member
There was a problem hiding this comment.
Without the reference to textwrap.dedent, the new notes are weird.
What other characters than the ones used in Python's indentation should be considered?
How would have empty line been normalized otherwise?
I suggest removing the note in use-facing docs, and in the internals, mentioning textwrap.dedent as a base for the comparison.
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@picnixz's preferred alternative to correcting (& testing fully) the behavior in #138620.
📚 Documentation preview 📚: https://cpython-previews--138624.org.readthedocs.build/