gh-124111: Update Windows build to use Tcl/Tk 9.0.3#149477
Conversation
zware
force-pushed
the
update_windows_tcltk
branch
from
2402c8c to
6f8bf77
Compare
zware
force-pushed
the
update_windows_tcltk
branch
from
6f8bf77 to
d4d914f
Compare
|
!buildbot Windows |
|
🤖 New build scheduled with the buildbot fleet by @zware for commit d4d914f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149477%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
| <TkPatchLevel>$([System.Version]::Parse($(TkVersion)).Build)</TkPatchLevel> | ||
| <TkRevision>$([System.Version]::Parse($(TkVersion)).Revision)</TkRevision> | ||
| <tclDir Condition="$(tclDir) == ''">$(ExternalsDir)tcl-core-$(TclVersion)\</tclDir> | ||
| <tclDir Condition="$(tclDir) == ''">$(ExternalsDir)tcl-$(TclVersion)\</tclDir> |
There was a problem hiding this comment.
This directory name should be under our control, isn't it? Why would we change the pattern (and break anyone who might be trying to pin back to an earlier version)?
There was a problem hiding this comment.
The tcl vs tcl-core distinction comes from which package we start with from https://sourceforge.net/projects/tcl/files/Tcl/9.0.3/. For the past several versions, we've been actually using tclx.y.z-src.ext rather than tcl-corex.y.z-src.ext even though we've been tagging it as tcl-core-x.y.z.0. I'd rather tag it as it originated, and the distinction between the two doesn't seem as worth pursuing to me as it did back when we switched to the -core variant, so this time I imported the regular tcl9.0.3-src.tar.gz and tagged it as such.
I'm not too concerned about this breaking pins; this would only affect anyone building their own from source and there's a good chance that anyone doing that would already be overriding tclDir as a whole just like we do in our tcltk-build workflow. They'll be more broken by the 8->9 transition anyway, just like we were.
I'd rather keep the changed naming here, but as a transitional measure I could add some extra tags to cpython-source-deps to fill in missing -core/not for the past several Tcls?
3 participants
Uh oh!
There was an error while loading. Please reload this page.